-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
13/09 Daily Promotion #36317
13/09 Daily Promotion #36317
Commits on Sep 12, 2024
-
chore: Updated error handling (#36288)
## Description Added extra checks for better reporting Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.ImportExport" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10831607193> > Commit: 2a5049d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10831607193&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.ImportExport` > Spec: > <hr>Thu, 12 Sep 2024 13:31:10 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced CI workflow to provide clearer test results through improved commenting on pull requests based on test outcomes. - Introduced a failure flag mechanism to explicitly record test execution status. - **Bug Fixes** - Improved reliability of CI process by ensuring important logs and results are preserved and uploaded even on test failures. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Configuration menu - View commit details
-
Copy full SHA for 71b44a1 - Browse repository at this point
Copy the full SHA 71b44a1View commit details
Commits on Sep 13, 2024
-
chore: remove typography selection in app theming (#36110)
/ok-to-test tags="@tag.All" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Introduced new hooks for icon management: `useIconDensity` and `useIconSizing`. - **Improvements** - Refactored hooks to enhance performance by using `useMemo` instead of state management, leading to more efficient calculations for icon size, density, spacing, and typography. - Streamlined theme management by consolidating logic and removing unnecessary properties, improving clarity and maintainability. - Optimized CSS class name management within the `useCssTokens` hook for better performance. - **Bug Fixes** - Removed `fontFamily` property from various components, which may affect text rendering but simplifies font management. - **Documentation** - Updated comments and documentation to reflect changes in typography and theme handling. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10786030048> > Commit: a0d1258 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10786030048&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 10 Sep 2024 06:00:30 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Pawan Kumar <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 049a8a9 - Browse repository at this point
Copy the full SHA 049a8a9View commit details -
fix: IDE Header Height usage (#36297)
## Description Fixes incorrect usage of IDE Header Height which caused bug in the Menu location Fixes #36284 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10843283682> > Commit: 0868d06 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10843283682&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Fri, 13 Sep 2024 05:28:39 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Style** - Enhanced CSS properties for better rendering consistency across browsers in the Editor component. - Improved formatting for better readability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Configuration menu - View commit details
-
Copy full SHA for 511268e - Browse repository at this point
Copy the full SHA 511268eView commit details -
chore: JFR 24 hour script with logs file (#36041)
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10807975642> > Commit: 660a59d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10807975642&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Wed, 11 Sep 2024 08:50:21 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Introduced a new automated script for recording Java Flight Recorder (JFR) data over a 24-hour period, enhancing monitoring capabilities for Java applications. - The script captures thread profiles at hourly intervals, streamlining performance data collection without manual intervention. - Added a monitoring setup function that conditionally executes the JFR recording script based on environment configuration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Goutham Pratapa <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1760132 - Browse repository at this point
Copy the full SHA 1760132View commit details -
chore: [Plugin Action Editor] Convert to Module (#36305)
## Description CE PR for: appsmithorg/appsmith-ee#5134 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10845636973> > Commit: 1f40848 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10845636973&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Fri, 13 Sep 2024 08:48:25 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced flexibility for child components in the Plugin Action Editor, allowing single or multiple React nodes. - Introduced a new toolbar with a dropdown menu for additional actions. - Added components for converting actions into modules, including callouts and disablers for better user feedback. - **Bug Fixes** - Improved user experience by providing notifications during the action conversion process. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Configuration menu - View commit details
-
Copy full SHA for f593ed3 - Browse repository at this point
Copy the full SHA f593ed3View commit details -
test: fix failing table filter spec by rearranging steps. (#36303)
## Description In the spec, feature flag intercept is interfering with navigating back to editor flow. Since we need FF in the editor, this PR rearranges these steps. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Table" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/10845920958> > Commit: c7de064 > Workflow: `PR Automation test suite` > Tags: `@tag.Table` > Spec: `` > <hr>Fri, 13 Sep 2024 08:40:08 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved test flow for the Table V2 component by repositioning navigation actions, enhancing clarity and context. - **Chores** - Updated the configuration for limited tests to focus on the Table V2 widget's filtering functionality instead of template-related tests. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Configuration menu - View commit details
-
Copy full SHA for 5996f74 - Browse repository at this point
Copy the full SHA 5996f74View commit details -
chore: exclude test for gitautocommit (#36307)
## Description Excluding test case Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.ImportExport" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10846188820> > Commit: 169260d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10846188820&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.ImportExport` > Spec: > <hr>Fri, 13 Sep 2024 09:22:22 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated the "Git Autocommit" test suite to include a new tag for exclusion in airgap environments, enhancing test execution strategy for isolated systems. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Configuration menu - View commit details
-
Copy full SHA for 6d64812 - Browse repository at this point
Copy the full SHA 6d64812View commit details -
chore: remove filled icon style setting (#36300)
Fixes #35175 /ok-to-test tags="@tag.Anvil" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10845022776> > Commit: 9224955 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10845022776&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Fri, 13 Sep 2024 08:02:36 UTC <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Simplified theme management by removing icon style options from the user interface. - **Bug Fixes** - Enhanced clarity in theme handling by refining type usage in various components. - **Chores** - Removed deprecated icon style properties and constants to streamline code and improve maintainability. - Deleted a test case related to icon styles to focus testing efforts elsewhere. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Pawan Kumar <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7e98542 - Browse repository at this point
Copy the full SHA 7e98542View commit details -
feat: auto select parent of the removed component (#36282)
## Description https://github.com/user-attachments/assets/764917aa-74ea-4c1b-8361-6441344227fd Fixes #36281 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10845273743> > Commit: 88d0b70 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10845273743&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 13 Sep 2024 09:32:43 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new optional `parentId` property for enhanced widget selection, allowing for hierarchical management. - Updated widget selection and deletion processes to utilize the `parentId` for improved contextual handling based on layout type. - **Bug Fixes** - Enhanced logic in widget selection to ensure the correct parent ID is used, improving overall selection accuracy. - **Documentation** - Updated documentation to reflect changes in widget selection and deletion functionalities. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Configuration menu - View commit details
-
Copy full SHA for ce02d3c - Browse repository at this point
Copy the full SHA ce02d3cView commit details -
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated Caddy web server configuration to allow broader accessibility to the admin interface. - **Security Notice** - The admin interface is now accessible from any IP address, which may require enhanced security measures to protect against unauthorized access. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Configuration menu - View commit details
-
Copy full SHA for eb0311a - Browse repository at this point
Copy the full SHA eb0311aView commit details -
fix: Fix the issue for the reverse PR comment (#36308)
## Description Fix the issue as flag value was interchange. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.ImportExport" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10846876122> > Commit: aa17588 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10846876122&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.ImportExport` > Spec: > <hr>Fri, 13 Sep 2024 10:01:50 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Adjusted the logic for adding comments on pull requests based on CI test results, improving clarity of feedback. - Enhanced conditions for commenting on new CI failures and successful jobs to provide more accurate notifications. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Configuration menu - View commit details
-
Copy full SHA for d6a1500 - Browse repository at this point
Copy the full SHA d6a1500View commit details -
Configuration menu - View commit details
-
Copy full SHA for de72d92 - Browse repository at this point
Copy the full SHA de72d92View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5b29b4 - Browse repository at this point
Copy the full SHA f5b29b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31a0d0e - Browse repository at this point
Copy the full SHA 31a0d0eView commit details -
fix: trim db urls and remove special characters during backup restore (…
…#36201) fixes: #36176 <!-- This is an auto-generated comment: Cypress test results --> > [!WARNING] > Tests have not run on the HEAD dd01ffd yet > <hr>Fri, 13 Sep 2024 10:38:44 UTC <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved handling of database URLs by removing leading and trailing whitespace, enhancing robustness and preventing potential issues. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Configuration menu - View commit details
-
Copy full SHA for 9398cf4 - Browse repository at this point
Copy the full SHA 9398cf4View commit details -
chore: Running on failure only (reverting to original) (#36315)
## Description Reverting to previous version as this steps specifically run for failure. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.ImportExport" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10848068018> > Commit: d646576 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10848068018&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.ImportExport` > Spec: > <hr>Fri, 13 Sep 2024 11:26:38 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated workflow conditions to trim Cypress log files only on job failures, improving log management for successful runs. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Configuration menu - View commit details
-
Copy full SHA for ba6fd9b - Browse repository at this point
Copy the full SHA ba6fd9bView commit details