Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

05/09 Daily Promotion #36124

Merged
merged 13 commits into from
Sep 5, 2024
Merged

05/09 Daily Promotion #36124

merged 13 commits into from
Sep 5, 2024

Commits on Sep 2, 2024

  1. fix: postgres plugin blocking call (#36046)

    ## Description
    This PR resolves the blockhound callout `Blocking call!
    java.io.FileInputStream#readBytes` in the /v1/actions/execute (POST) API
    call when used with Postgres Plugin.
    This blocking call was present in the PostgresPlugin.java
    
    Fixes #36008   
    
    ## Automation
    
    /ok-to-test tags="@tag.Sanity"
    
    ### 🔍 Cypress test results
    <!-- This is an auto-generated comment: Cypress test results  -->
    > [!IMPORTANT]
    > 🟣 🟣 🟣 Your tests are running.
    > Tests running at:
    <https://github.com/appsmithorg/appsmith/actions/runs/10666128697>
    > Commit: 9224297
    > Workflow: `PR Automation test suite`
    > Tags: `@tag.Sanity`
    > Spec: ``
    > <hr>Mon, 02 Sep 2024 11:19:10 UTC
    <!-- end of auto-generated comment: Cypress test results  -->
    
    
    ## Communication
    Should the DevRel and Marketing teams inform users about this change?
    - [ ] Yes
    - [ ] No
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    
    - **Chores**
    - Improved the readability and conciseness of the connection pool
    creation logic in the Postgres plugin, enhancing maintainability without
    affecting functionality.
    - Updated logging level from debug to info for better clarity on log
    messages.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    NilanshBansal authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    4516129 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Configuration menu
    Copy the full SHA
    f02b448 View commit details
    Browse the repository at this point in the history
  2. chore: Added pg branch (#36086)

    ## Description
    Run the CI test limit in PG branch
    
    
    Fixes #`36085`  
    
    
    ## Automation
    
    /ok-to-test tags="@tag.Sanity"
    
    ### 🔍 Cypress test results
    <!-- This is an auto-generated comment: Cypress test results  -->
    > [!TIP]
    > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
    > Workflow run:
    <https://github.com/appsmithorg/appsmith/actions/runs/10683137823>
    > Commit: 288bb1a
    > <a
    href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10683137823&attempt=1"
    target="_blank">Cypress dashboard</a>.
    > Tags: `@tag.Sanity`
    > Spec:
    > <hr>Tue, 03 Sep 2024 13:03:06 UTC
    <!-- end of auto-generated comment: Cypress test results  -->
    
    
    ## Communication
    Should the DevRel and Marketing teams inform users about this change?
    - [ ] Yes
    - [x] No
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    - **New Features**
    - Introduced a new output variable `is-pg-build` to enhance build
    handling based on pull request base branches.
    - Improved workflow logic to conditionally manage builds depending on
    the pull request context.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    sagar-qa007 authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6ad6a11 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. feat: disable create js object option in workflows editor (#36094)

    ## Description
    
    Workflows is not currently supporting multiple js objects. Hence, we
    need to disable the option for the workflows editor.
    
    EE branch: appsmithorg/appsmith-ee#5027
    
    Fixes #32239 
    
    ## Automation
    
    /test js
    
    ### 🔍 Cypress test results
    <!-- This is an auto-generated comment: Cypress test results  -->
    > [!TIP]
    > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
    > Workflow run:
    <https://github.com/appsmithorg/appsmith/actions/runs/10686636668>
    > Commit: 5cb101f
    > <a
    href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10686636668&attempt=1"
    target="_blank">Cypress dashboard</a>.
    > Tags: `@tag.JS`
    > Spec:
    > <hr>Tue, 03 Sep 2024 16:45:16 UTC
    <!-- end of auto-generated comment: Cypress test results  -->
    
    
    ## Communication
    Should the DevRel and Marketing teams inform users about this change?
    - [ ] Yes
    - [x] No
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    - **New Features**
    - Enhanced logic for creating new JavaScript objects, preventing
    unnecessary additions in the workflow editor.
    - Introduced a function to determine if creating a new JavaScript object
    is allowed, improving user experience in the workflow editor.
    - Improved responsiveness of the Files component based on the parent
    entity type, allowing for context-sensitive behavior.
    
    - **Bug Fixes**
    - Addressed limitations in workflow runner support for multiple
    JavaScript objects.
    
    - **Refactor**
    - Simplified the `onCreate` function's dependencies for improved clarity
    and functionality.
      
    - **Tests**
    - Added new test cases to validate the behavior of JavaScript object
    creation options based on user settings.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    ayushpahwa authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    72d1815 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5bed1fc View commit details
    Browse the repository at this point in the history
  3. ci: add configs for release to pg sync (#35914)

    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    
    - **Workflow Improvements**
    - Enhanced GitHub Actions workflow for syncing releases, improving Git
    operations and conflict management.
    - Introduced a step to set Git configuration for better commit
    attribution.
    - Added a new step to specify the Node.js version for consistent
    environment setup.
    - Simplified the merging process with a new `git merge` command that
    accommodates unrelated histories.
    - Adjusted conflict handling strategy, emphasizing manual intervention
    when conflicts occur.
    	- Updated Slack notification message formatting for clarity.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    
    <!-- This is an auto-generated comment: Cypress test results  -->
    > [!WARNING]
    > Tests have not run on the HEAD
    f30933c yet
    > <hr>Tue, 03 Sep 2024 04:18:19 UTC
    <!-- end of auto-generated comment: Cypress test results  -->
    AnaghHegde authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    95537e0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4a0c9e8 View commit details
    Browse the repository at this point in the history
  5. fix: fixed back button to redirect to applications page (#35900)

    added the changes to redirect to application pages instead of going back
    in the history.
    
    issue: [#34431](#34431)
    
    fixed the navigation to not go back in history
    The navigation of the back button used to go back in history. Now it
    will be redirected to the expected page.
    
    added the test for profile page:
    
    ![image](https://github.com/user-attachments/assets/18dcd56f-dab9-4b9c-8ade-9976b96a361f)
    
    added the tests for settings page:
    
    ![image](https://github.com/user-attachments/assets/869fd21a-edf3-4ec9-ad68-bf3eea5d54e1)
    
    video:
    
    
    https://github.com/user-attachments/assets/35a805ec-a579-4571-b4c6-e415f0f5c5f3
    
    
    
    ## Automation
    
    /ok-to-test tags="@tag.All"
    
    ### 🔍 Cypress test results
    <!-- This is an auto-generated comment: Cypress test results  -->
    > [!TIP]
    > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
    > Workflow run:
    <https://github.com/appsmithorg/appsmith/actions/runs/10659602683>
    > Commit: 23f2285
    > <a
    href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10659602683&attempt=3"
    target="_blank">Cypress dashboard</a>.
    > Tags: `@tag.All`
    > Spec:
    > <hr>Mon, 02 Sep 2024 04:52:56 UTC
    <!-- end of auto-generated comment: Cypress test results  -->
    
    
    
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    
    - **New Features**
    - Enhanced navigation for the BackButton in both UserProfile and
    Settings components, directing users to the applications page and
    specific workspace pages, respectively.
    
    - **Bug Fixes**
    - Improved test coverage for BackButton interactions in both UserProfile
    and Settings components, ensuring correct navigation behavior is
    verified.
    
    - **Tests**
    - Expanded test suite for UserProfile and Settings components,
    incorporating better routing and interaction simulations.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    saicharan-zemoso authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    420dc9b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2a6885a View commit details
    Browse the repository at this point in the history
  7. fix: Updating the CSS to place the meatball icon in the correct place…

    … for Application Card (#36112)
    
    ## Description
    
    Updating the CSS to place the meatball icon in the correct place for
    Application Card
    
    Fixes [#36084 ](#36084)
    
    ## Automation
    
    /ok-to-test tags="@tag.Sanity"
    
    ### 🔍 Cypress test results
    <!-- This is an auto-generated comment: Cypress test results  -->
    > [!TIP]
    > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
    > Workflow run:
    <https://github.com/appsmithorg/appsmith/actions/runs/10697709457>
    > Commit: 8750fd8
    > <a
    href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10697709457&attempt=2"
    target="_blank">Cypress dashboard</a>.
    > Tags: `@tag.Sanity`
    > Spec:
    > <hr>Wed, 04 Sep 2024 08:41:00 UTC
    <!-- end of auto-generated comment: Cypress test results  -->
    
    
    ## Communication
    Should the DevRel and Marketing teams inform users about this change?
    - [ ] Yes
    - [ ] No
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    - **New Features**
    - Enhanced the layout of the Card component's footer for a more balanced
    appearance.
    
    - **Style**
    - Introduced a new CSS property to improve spacing between elements in
    the CardFooter.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    ankitakinger authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    50bbc49 View commit details
    Browse the repository at this point in the history
  8. fix: removed conditional to check for jslib files (#36115)

    ## Description
    - Modified file writing logic for custom js lib writing logic
    
    Fixes #32734
    
    > [!WARNING]  
    > _If no issue exists, please create an issue first, and check with the
    maintainers if the issue is valid._
    
    ## Automation
    
    /ok-to-test tags="@tag.Git"
    
    ### 🔍 Cypress test results
    <!-- This is an auto-generated comment: Cypress test results  -->
    > [!TIP]
    > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
    > Workflow run:
    <https://github.com/appsmithorg/appsmith/actions/runs/10699103627>
    > Commit: fe25da5
    > <a
    href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10699103627&attempt=1"
    target="_blank">Cypress dashboard</a>.
    > Tags: `@tag.Git`
    > Spec:
    > <hr>Wed, 04 Sep 2024 09:58:48 UTC
    <!-- end of auto-generated comment: Cypress test results  -->
    
    
    ## Communication
    Should the DevRel and Marketing teams inform users about this change?
    - [ ] Yes
    - [ ] No
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    
    - **Bug Fixes**
    - Simplified the logic for saving JavaScript libraries, which may
    improve performance but could affect when libraries are saved after
    modifications.
    
    - **Chores**
    	- Removed unnecessary import statement, streamlining the codebase.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    sondermanish authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    7d7a601 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. feat: Action redesign: Updating the config for SMTP plugin to use sec…

    …tions and zones format (#36091)
    
    ## Description
    
    Action redesign: Updating the config for SMTP plugin to use sections and
    zones format
    
    Fixes [#35505 ](#35505)
    
    ## Automation
    
    /ok-to-test tags="@tag.All"
    
    ### 🔍 Cypress test results
    <!-- This is an auto-generated comment: Cypress test results  -->
    > [!TIP]
    > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
    > Workflow run:
    <https://github.com/appsmithorg/appsmith/actions/runs/10704929692>
    > Commit: f58dfce
    > <a
    href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10704929692&attempt=2"
    target="_blank">Cypress dashboard</a>.
    > Tags: `@tag.All`
    > Spec:
    > <hr>Wed, 04 Sep 2024 19:46:08 UTC
    <!-- end of auto-generated comment: Cypress test results  -->
    
    
    ## Communication
    Should the DevRel and Marketing teams inform users about this change?
    - [ ] Yes
    - [ ] No
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    - **New Features**
    - Introduced a comprehensive email sending interface in the SMTP plugin,
    allowing users to input recipient addresses, subject, body type, and
    attachments.
    - Enhanced layout with a new `DOUBLE_COLUMN_ZONE` structure for improved
    organization of input fields.
    
    - **Improvements**
    - Expanded styling capabilities for the dynamic input text control,
    allowing for more flexible sizing and better responsiveness in the UI.
    - Updated existing configurations to streamline the email composition
    process and improve user experience.
    
    - **Bug Fixes**
    - Adjusted CSS rules to remove minimum height and width constraints for
    better adaptability of UI components.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    ankitakinger authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5aa9392 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    65eb854 View commit details
    Browse the repository at this point in the history