Skip to content

Commit

Permalink
test: remove redundant select workspace in cypres test (#36138)
Browse files Browse the repository at this point in the history
## Description

The spec MemberRoles started failing on PG branch(both ce and ee)
recently. In this spec the last step, which asserts the user with view
permission leaving workspace was failing. `the
_.homePage.LeaveWorkspace(workspaceId);` internally calls for
`_.homePage.SelectWorkspace(workspaceId);`

## Automation

/ok-to-test tags="@tag.Workspace"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10736154328>
> Commit: c9203b7
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10736154328&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Workspace`
> Spec:
> <hr>Fri, 06 Sep 2024 10:04:45 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Updated the test flow for workspace member roles to ensure accurate
simulation of user behavior when leaving a workspace.
  
- **Chores**
- Modified the limited tests configuration to focus on member roles,
removing the previous test for template for improved testing relevance.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
AnaghHegde authored Sep 6, 2024
1 parent d37e8d2 commit 08ec688
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ describe(
);
if (CURRENT_REPO === REPO.EE)
_.adminSettings.EnableGAC(false, true, "home");
_.homePage.SelectWorkspace(workspaceId);
_.homePage.LeaveWorkspace(workspaceId);
});
},
Expand Down

0 comments on commit 08ec688

Please sign in to comment.