Skip to content

Commit

Permalink
Fix embarrassing timeout bug with worker process
Browse files Browse the repository at this point in the history
Not sure why I thought Popen's process wait function needed a loop!
  • Loading branch information
ctrueden committed Dec 1, 2023
1 parent 8c322a9 commit 89c6549
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/appose/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,7 @@ def _stderr_loop(self) -> None:

def _monitor_loop(self) -> None:
# Wait until the worker process terminates.
while self._process.wait(50) is None:
pass
self._process.wait()

# Do some sanity checks.
exit_code = self._process.returncode
Expand Down

0 comments on commit 89c6549

Please sign in to comment.