Fix file watcher excludes issue #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laggingreflex
force-pushed
the
excludes
branch
from
c63cfce
to
e75ca26
Compare
Prior to this the File watcher (chokidar) wasn't actually ignoring the excludes. It only excludes either when both the exclude paths and watch path are relative or when both are absolute. We had watch path as an absolute path and ignored paths as relative paths. In this case it is required to have `cwd` option passed in for it to work. Also use `anymatch` instead of `minimatch` With these changes we can now have exclude patterns like `.git`, or `node_modules`, instead of `.git/**` and `.git/**/*` or `**/.git/**`.
laggingreflex
force-pushed
the
excludes
branch
from
e75ca26
to
308fe24
Compare
|
Sweet, sorry again for the delay in merging these, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix file watcher excludes issue (#47)
Prior to this the File watcher (chokidar) wasn't actually ignoring the excludes. It is required to have
cwdoption passed in for it to work. (small discussion on the issue here)Also use
anymatchinstead ofminimatch. It better handles matching both globbed and non-globbed paths.With these changes we can now simply have exclude patterns like
.git, ornode_modules(instead of.git/**and.git/**/*or**/.git/**)