Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Reference Handling of Custom Terminating Byte Sequences #625

Merged

Conversation

paulhdk
Copy link
Contributor

@paulhdk paulhdk commented Sep 17, 2024

Motivation

See: apple/swift-openapi-runtime#115

Modifications

This PR references the changes introduced by TODO in the documentation.

Result

Users planning to generate code for OpenAPI specs with custom terminating byte sequences will hopefully find it easier to make the necessary changes in their code.

Please let me know if there are other places where these changes could be mentioned.

Test Plan

.

@czechboy0
Copy link
Collaborator

Thanks for the extra care for the documentation here 🙂 Let's get to this once apple/swift-openapi-runtime#115 lands in its final form (since we're still iterating on the details).

@simonjbeaumont simonjbeaumont added area/documentation Improvements or additions to documentation. status/blocked Waiting for another issue. labels Sep 17, 2024
Copy link
Collaborator

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get these updated and it's ready to go

@czechboy0 czechboy0 enabled auto-merge (squash) October 3, 2024 17:37
@czechboy0 czechboy0 merged commit de51f3d into apple:main Oct 3, 2024
24 checks passed
@paulhdk paulhdk deleted the customisable-terminating-byte-sequence branch October 4, 2024 15:15
@czechboy0 czechboy0 added semver/none No version bump required. and removed area/documentation Improvements or additions to documentation. status/blocked Waiting for another issue. labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling non-JSON payloads with asDecodedServerSentEventsWithJSONData()
3 participants