Skip to content

Add a new Socket Stream Protocol - #47

Open
PayasR wants to merge 2 commits into
mainfrom
payasr/SocketProtocol
Open

Add a new Socket Stream Protocol#47
PayasR wants to merge 2 commits into
mainfrom
payasr/SocketProtocol

Conversation

@PayasR

@PayasR PayasR commented Jul 13, 2026

Copy link
Copy Markdown

This lets us use Kernel TCP socket streams for when userspace TCP isn't available.

@PayasR
PayasR requested a review from holleman July 13, 2026 17:44
@PayasR PayasR changed the title Adds a new Socket Stream Protocol Add a new Socket Stream Protocol Jul 13, 2026
@PayasR
PayasR force-pushed the payasr/SocketProtocol branch 2 times, most recently from 1d6247e to 27f4de0 Compare July 13, 2026 18:53

@agnosticdev agnosticdev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things, mainly on creating test harness code.

Comment thread Tests/SwiftNetworkTests/SwiftNetworkSocketTests.swift Outdated
Comment thread Tests/SwiftNetworkTests/SwiftNetworkSocketTests.swift
Comment thread Sources/Tools/SocketTransfer/main.swift Outdated
Comment thread Sources/SwiftNetwork/System/SystemSocket.swift Outdated

@agnosticdev agnosticdev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, it just looks like there are some linux test failures outstanding.

let harness = UDPLoopbackHarness(basePort: 10840)
harness.start()
harness.expectDeliver([0xFF])
harness.teardown()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is exactly what we want, thanks!

@PayasR
PayasR force-pushed the payasr/SocketProtocol branch from f9d3b02 to 471a92d Compare August 7, 2026 17:02
@PayasR
PayasR force-pushed the payasr/SocketProtocol branch 7 times, most recently from d7ce9c2 to 3d977ac Compare August 7, 2026 19:24
@PayasR
PayasR force-pushed the payasr/SocketProtocol branch from 3d977ac to 3967965 Compare August 7, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants