feat: Add swift wasm compilation support to swift-distributed-tracing #174
+66
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for compiling swift-distributed-tracing to wasm using the SwiftWasm sdk.
This PR is part of a larger effort by a company called PassiveLogic to enable broad support for SwiftWasm.
Details
There are three changes required to enable wasm compilation for swift-distributed-tracing.
import Dispatch
imports. SwiftWasm doesn't currently include GCD. Luckily, all usage of GCD was unused.Testing done
swift build
completes without errorsswift build --swift-sdk wasm32-unknown-wasi
completes without errorsswift build --swift-sdk wasm32-unknown-wasip1-threads
completes without errorsswift package --swift-sdk wasm32-unknown-wasip1-threads js --use-cdn
Impact Risk
Realistically, this change should not cause any impact or risk. Outside of wasm targets, the changes in this PR are additive.