Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly declare the ServiceContext dependency #147

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

sidepelican
Copy link
Contributor

In my project, every first clean build causes the next error.

/my_project/.build/checkouts/swift-distributed-tracing/Sources/Tracing/InstrumentationSystem+Tracing.swift:15:19: error: missing required module 'ServiceContextModule'
@_exported import Instrumentation

and this error does not appear when retrying the build.
In practice, this is caused by an implicit dependency through another target and the use of @_exported, so we need to declare the dependency explicitly.

  • environment
# swift --version
Swift version 5.10 (swift-5.10-RELEASE)
Target: aarch64-unknown-linux-gnu

Copy link
Collaborator

@slashmo slashmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 🙏

@ktoso
Copy link
Member

ktoso commented Jul 19, 2024

@swift-server-bot test this please

@ktoso ktoso enabled auto-merge (squash) July 19, 2024 05:02
@ktoso
Copy link
Member

ktoso commented Jul 19, 2024

Thanks, lgtm!

@ktoso ktoso added this to the 1.1.1 milestone Jul 19, 2024
@ktoso ktoso merged commit 72d831a into apple:main Jul 19, 2024
3 of 6 checks passed
@sidepelican sidepelican deleted the fix_target_deps branch July 19, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants