-
Notifications
You must be signed in to change notification settings - Fork 199
opentelemetry-http: Add documentation #3340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
servicetalk-examples/docs/modules/ROOT/pages/_partials/nav-versioned.adoc
Outdated
Show resolved
Hide resolved
servicetalk-opentelemetry-http/docs/modules/ROOT/pages/index.adoc
Outdated
Show resolved
Hide resolved
servicetalk-opentelemetry-http/docs/modules/ROOT/pages/index.adoc
Outdated
Show resolved
Hide resolved
...main/java/io/servicetalk/examples/http/opentelemetry/tracing/OpenTelemetryTracingClient.java
Show resolved
Hide resolved
|
||
For complete working examples, see the OpenTelemetry examples in the ServiceTalk examples module. | ||
|
||
== Related Documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding screenshots from Jaeger to demonstrate how traces look like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I'd prefer to pass on this: there are many different examples of Jaeger out there.
Motivation
The OTEL filters are non-trivial to use as there is some degree of dependency
on other filters, but there isn't a good way for people to know this.
Modifications
Add some docs.
Result
It's easier to understand how to use OTEL support.