client-api: Add weight as field on ServiceDiscovererEvent #2901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We're trying out a couple API's that let us add additional metadata to the endpoints provided by ServiceDiscoverer. Modifications: This example makes the weight metadata a first class concept on the ServiceDiscovererEvent interface. I think there are some pros and cons Pros: - It's clean. - It's very clear what the data is and where it comes from. Cons: - Everything that needs to be passed through must become a field. - Right now the protocol defines three key parts: (address, status, metadata) where metadata is 'everything else'. Making meta-data first class fields muddies the waters a bit. - Changing the meta-data requires making a proxy class and that will rely on all underlying proxies to forward correct data, eg not use the default.
bryce-anderson
requested review from
daschl,
idelpivnitskiy,
mgodave and
tkountis
Contributor
Author
|
Going to close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2902 for a counter proposal using a map like abstraction.
Motivation:
We're trying out a couple API's that let us add additional metadata to the endpoints provided by ServiceDiscoverer.
Modifications:
This example makes the weight metadata a first class concept on the ServiceDiscovererEvent interface.
I think there are some pros and cons
Pros:
Cons: