Skip to content

Fix clog longer than test duration #12452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix clog longer than test duration #12452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion fdbserver/workloads/DcLag.actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ struct DcLagWorkload : TestWorkload {
TraceEvent("DcLag").detail("StartTime", startTime).detail("EndTime", workloadEnd);

// Clog and wait for recovery to happen
if (!self->clogTlog(self->testDuration)) {
double clogDuration = self->testDuration * (0.5 + 0.4 * deterministicRandom()->random01());
Copy link
Member Author

@kakaiu kakaiu Oct 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not put this into a method because whether using a shorten clogDuration depends on workload. There are some workloads use clogTlog which wants to clog a pair almost forever.

Copy link
Member Author

@kakaiu kakaiu Oct 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if you have any preference. Thanks! @gxglass

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testDuration = 200.0 in DcLag.toml, which doesn't seem to be very long. And after the test finishes, unclogAll() should remove the clogging.

Can you explain the failure you've seen?

if (!self->clogTlog(clogDuration)) {
return Void(); // skip the test if no satellite found
}

Expand Down
3 changes: 2 additions & 1 deletion fdbserver/workloads/FailoverWithSSLag.actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,8 @@ struct FailoverWithSSLagWorkload : TestWorkload {
}

// Clog connections between remote tlogs and storage servers.
if (!self->findAndClogRemoteStorages(self->testDuration)) {
double clogDuration = self->testDuration * (0.5 + 0.4 * deterministicRandom()->random01());
if (!self->findAndClogRemoteStorages(clogDuration)) {
// Couldn't find remote tlogs/storage servers. Probably configuration will
// need to be adjusted.
self->testSuccess = false;
Expand Down