Support bool type for torch triu. #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobyRoseman
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Thanks for the enhancement. Code looks good. One minor comment.
CI: https://gitlab.com/coremltools1/coremltools/-/pipelines/1609408368
| params_dict = {} | ||
| if diagonal is not None: | ||
| params_dict["diagonal"] = diagonal | ||
| model = ModuleWrapper(torch.triu, params_dict) | ||
| input_data = torch.randn(shape) |
There was a problem hiding this comment.
Doesn't really make sense to populate this only to have it usually overriden. I'd put this line in an else-block.
|
@fukatani - In order to get a clean CI run, you need to rebase on top of the latest |
|
@TobyRoseman |
TobyRoseman
approved these changes
Jan 9, 2025
|
Thanks @fukatani |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.