Extension to InputContext design: adding per-graph descriptors - #162
Open
carinapeng wants to merge 1 commit into
Open
Extension to InputContext design: adding per-graph descriptors#162carinapeng wants to merge 1 commit into
carinapeng wants to merge 1 commit into
Conversation
carinapeng
requested review from
alejandro-isaza,
blevine1,
kevchengcodes and
tjia1818
August 11, 2026 23:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
descriptors: [String: NDArrayDescriptor]field toInputContext(from #147) so an input handler can size its output buffer to the running graph's shape. Backward-compatible: defaults to empty, and the dynamic path is unchanged.Why
Static-shape / bucketed engines select a different graph per step, so a handler (position ids, causal mask, RoPE, PLE, ...) needs the active graph's input descriptors to allocate correctly.
InputContextdidn't carry them.Change
descriptorsfield; threaded through.dynamic()(empty) and.static()(optional, defaults empty).SyncInputHandlerprotocol or existing callers.Enabling change for the static-shape engine (PR to follow).