Remove the images a fixture's builds register - #2179
Closed
MayCXC wants to merge 1 commit into
Closed
Conversation
The fixture's contract is that every resource created during a test's scope is torn down when the scope exits. The build helpers registered images in the store and left no removal behind, so an integration run accumulated one set of uniquely tagged build products per run, held beyond the run by nothing. Register removal for every tag a successful build lands, including the runtime generated tag a tagless build prints. Removal tolerates a tag the local exporter never registered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
The fixture's contract is that every resource created during a test's scope is torn down when the scope exits. The build helpers registered images in the store and left no removal behind, so an integration run accumulated one set of uniquely tagged build products per run, held beyond the run by nothing.
Removal is registered for every tag a successful build lands, including the runtime generated tag a tagless build prints, and tolerates a tag the local exporter never registered.
Test support only; no product code changes. Related to the disk pressure catalogued in #2164, which this contributes to and does not fix by itself: the images this leaves behind each hold an unpacked snapshot that the leaks in that issue then keep.
Testing
An integration run that previously left one image per build per run now leaves none.
Integration suite: 397 passed. Unit suite: 772 passed.
make fmt,make checkclean.