Say which half of the CNI manifest lookup failed - #2178
Closed
MayCXC wants to merge 1 commit into
Closed
Conversation
The manifest ships beside the plugin binary, so finding it needs both the plugin that the running executable belongs to and the resources directory of that installation. One message covered the absence of either, naming neither the executable it looked for nor what was installed, and a run that hit it left nothing to tell the two apart. Each half now reports what it was looking for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
The CNI manifest ships beside the plugin binary, so finding it needs both the plugin that the running executable belongs to and the resources directory of that installation. One message covered the absence of either, naming neither the executable it looked for nor what was installed, and a run that hit it left nothing to tell the two apart: an installation missing its resources and a binary running from outside any installation produce the same sentence.
Each half reports what it was looking for now.
Diagnostics only; no behaviour changes.
Testing
Both halves exercised by running the k8s path from an executable outside an installation, and from an installation with its resources directory removed.
Integration suite: 397 passed. Unit suite: 772 passed.
make fmt,make checkclean.