Stop importing Testing from ContainerTestSupport - #2118
Open
Hashim1999164 wants to merge 1 commit into
Open
Conversation
Contributor
|
@Hashim1999164 The change looks good but you need signed, verified commits. |
katiewasnothere
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2052
ContainerTestSupport is a library product, so swift build compiles it outside a test target. Importing the Testing module there fails with no such module Testing, which breaks make all.
The assert helpers now throw CommandError.executionFailed with the same messages. Callers already use try, so test failures still surface. Unused Testing imports were removed as well.
Test plan
Confirmed Sources/ContainerTestSupport no longer imports Testing. Built the ContainerTestSupport product successfully with swift build.