Skip to content

feat: Add flutter integration driver commands and tests #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MummanaSubramanya
Copy link
Contributor

@KazuCocoa
Copy link
Member

KazuCocoa commented Sep 19, 2024

Could you add tests in unit test as possible instead of functional test?
https://github.com/appium/python-client/tree/master/test/unit

As a client, what http request should be sent is important but it does not need to test driver side. Driver's response can be a mock.

Existing functional tests include tests for appium project's drivers themselves. They would be removed as not necessary for client tests.

@KazuCocoa
Copy link
Member

KazuCocoa commented Sep 19, 2024

Could you use flutter_intergation namespace or flutter/flutter_integration?

@KazuCocoa
Copy link
Member

I left some comments.

  • convert tests to unit test to focus on each client method's input/output (fast and less flakiness as client)
    • Existing unit test should help to see how to check the http request's input/output as a client
  • name space
  • some code improvement

Thank you for the contribution, btw :)

@MummanaSubramanya
Copy link
Contributor Author

Could you use flutter_intergation namespace or flutter/flutter_integration?

updated

@MummanaSubramanya
Copy link
Contributor Author

@KazuCocoa @mykola-mokhnach Thank you very much for your review. I have addressed all the comments and added both unit tests and end-to-end tests. I'm happy to report that all tests have passed.

Copy link
Contributor

@mykola-mokhnach mykola-mokhnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mykola-mokhnach mykola-mokhnach merged commit 2ffa930 into appium:master Sep 23, 2024
18 of 19 checks passed
@Sanmejie
Copy link

Sanmejie commented Sep 23, 2024

image
The three methods provided in the diagram do not use the flutter integration driver commands feature, is there any other recommended method to install?

update
I successfully installed it by replacing the .py files

@KazuCocoa
Copy link
Member

KazuCocoa commented Sep 23, 2024

It is not released yet. I'll release this tonight. (for via pypi)

@KazuCocoa
Copy link
Member

4.2.0 is available now

@KazuCocoa KazuCocoa added size:M contribution size: M size:L contribution size: L and removed size:M contribution size: M labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L contribution size: L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants