-
Notifications
You must be signed in to change notification settings - Fork 570
feat: Add flutter integration driver commands and tests #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add flutter integration driver commands and tests #1022
Conversation
Could you add tests in unit test as possible instead of functional test? As a client, what http request should be sent is important but it does not need to test driver side. Driver's response can be a mock. Existing functional tests include tests for appium project's drivers themselves. They would be removed as not necessary for client tests. |
Could you use |
I left some comments.
Thank you for the contribution, btw :) |
updated |
appium/webdriver/extensions/flutter_integration/scroll_directions.py
Outdated
Show resolved
Hide resolved
appium/webdriver/extensions/flutter_integration/flutter_commands.py
Outdated
Show resolved
Hide resolved
@KazuCocoa @mykola-mokhnach Thank you very much for your review. I have addressed all the comments and added both unit tests and end-to-end tests. I'm happy to report that all tests have passed. |
appium/webdriver/extensions/flutter_integration/flutter_commands.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @MummanaSubramanya
It is not released yet. I'll release this tonight. (for via pypi) |
4.2.0 is available now |
Addressing AppiumTestDistribution/appium-flutter-integration-driver#52