Repository navigation
fix: update executor and driver server URL state on directConnect - #2500
Open
hoanle0126 wants to merge 1 commit into
Open
hoanle0126 wants to merge 1 commit into
hoanle0126 wants to merge 1 commit into
Conversation
hoanle0126
requested review from
SrinivasanTarget,
mykola-mokhnach,
saikrishna321 and
valfirst
as code owners
November 12, 2026 16:27
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
AppiumCommandExecutor.overrideServerUrlto refresh the stored client configuration and remote server address alongside the HTTP client, and populate the base URL fromAppiumDriverLocalServicewhen omitted in the client configuration.AppiumDriver.getRemoteAddressto the active command executor so callers (includingSeleniumBridgeand log listeners) observe the updated server URL afterdirectConnector subsequent URL overrides.DirectConnect.Types of changes
Details
After the command executor became standalone in v11,
overrideServerUrlcreated a new HTTP client with the overridden base URL without updating the executor fields. That leftgetAddressOfRemoteServer(), the driver remote address, and the Selenium bridge client configuration pointing to the initial hub URL after direct connect.Added unit tests covering executor state updates, Selenium bridge client configuration propagation, local service base URL fallback, and IPv6 / path / blank-capability cases.