Repository navigation
feat(pagefactory): support custom @PageFactoryFinder locator annotations - #2499
Open
hoanle0126 wants to merge 1 commit into
Open
hoanle0126 wants to merge 1 commit into
hoanle0126 wants to merge 1 commit into
Conversation
hoanle0126
requested review from
SrinivasanTarget,
mykola-mokhnach,
saikrishna321 and
valfirst
as code owners
November 11, 2026 05:32
hoanle0126
force-pushed
the
feat/custom-findby-annotations
branch
from
November 11, 2026 05:36
5810b53 to
a0789c5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #1043
@PageFactoryFinderandAnnotationstoio.appium.java_client.support, and attach finder metadata to the built-in FindBy, FindBys, and FindAll annotations.DefaultElementByBuilderandDefaultFieldDecoratorto resolve custom locator annotations extendingAbstractFindByBuilderacross single elements, element lists, widgets (both field-level and class-level), and By / AppiumBy fields.org.openqa.selenium.support.PageFactoryFindercustom annotations reflectively inSeleniumAnnotationsCompatwhen selenium-support is on the classpath, and include the new types in the v11 OpenRewrite migration recipe and guide.IllegalArgumentExceptionusing the declared annotation names.Types of changes