-
-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flutter driver commands to support camera mocking #2207
Merged
saikrishna321
merged 5 commits into
appium:master
from
sudharsan-selvaraj:feat/flutter_camera_mocking
Jul 25, 2024
Merged
feat: add flutter driver commands to support camera mocking #2207
saikrishna321
merged 5 commits into
appium:master
from
sudharsan-selvaraj:feat/flutter_camera_mocking
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudharsan-selvaraj
requested review from
mykola-mokhnach,
SrinivasanTarget,
saikrishna321 and
valfirst
as code owners
July 24, 2024 05:39
src/main/java/io/appium/java_client/flutter/SupportsFlutterCameraMocking.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/flutter/SupportsFlutterCameraMocking.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/flutter/SupportsFlutterCameraMocking.java
Outdated
Show resolved
Hide resolved
valfirst
requested changes
Jul 24, 2024
src/e2eFlutterTest/java/io/appium/java_client/android/CommandTest.java
Outdated
Show resolved
Hide resolved
src/e2eFlutterTest/java/io/appium/java_client/android/CommandTest.java
Outdated
Show resolved
Hide resolved
src/e2eFlutterTest/java/io/appium/java_client/android/CommandTest.java
Outdated
Show resolved
Hide resolved
mykola-mokhnach
approved these changes
Jul 24, 2024
SrinivasanTarget
approved these changes
Jul 25, 2024
saikrishna321
approved these changes
Jul 25, 2024
valfirst
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Flutter integration driver has support for mocking camera images. As part of this change, i have added new commands to handle and manage camera image injection.
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
x
in the boxes that applyDetails
Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted java code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub