WIP: Refactor: Centralize user management and persistence #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the SDK's user management by: - Introducing `UserRepository` to handle `ApphudUser` state and persistence. - Migrating `ApphudInternal` to delegate user operations to `UserRepository`. - Adding `UpdateCustomerUseCase` for customer data updates. - Converting `SharedPreferencesStorage` to a class for better dependency injection. - Updating the demo app's `Apphud.start` call with new parameters.
…ator The SharedPreferencesStorage access mechanism has been redesigned. Instead of creating local instances in different classes, a single instance provided through ServiceLocator is now used. This change centralizes dependency management, simplifies the structure of the code, and improves its testability by eliminating the direct creation of dependencies within classes.
…e and related classes Removed userId and deviceId properties from Storage interface and their implementation in SharedPreferencesStorage, and removed references to them in ApphudInternal and UserRepository. Now user IDs are taken only from ApphudUser, which simplifies storage logic and prevents data duplication. This is a preparatory stage for further refactoring of work with users.
aaudin90
force-pushed
the
UserStorageRefactoring
branch
from
4c637c2 to
c5477ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the SDK's user management by:
UserRepositoryto handleApphudUserstate and persistence.ApphudInternalto delegate user operations toUserRepository.UpdateCustomerUseCasefor customer data updates.SharedPreferencesStorageto a class for better dependency injection.Apphud.startcall with new parameters.