-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix ocm machine pools #4710
Closed
Closed
Bugfix ocm machine pools #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esron
force-pushed
the
bugfix-ocm-machine-pools
branch
2 times, most recently
from
October 14, 2024 20:26
bd54a00
to
dc13bea
Compare
Can you explain what you're trying to fix, and link to a Jira issue? |
esron
force-pushed
the
bugfix-ocm-machine-pools
branch
from
October 16, 2024 12:43
003dd24
to
4afa9ff
Compare
esron
force-pushed
the
bugfix-ocm-machine-pools
branch
from
October 16, 2024 19:37
4afa9ff
to
5af0959
Compare
Sure, I'll update the description. |
I'm gonna close this in favor of #4738 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: APPSRE-10481
The objective of this update is:
To prevent
ocm-machine-pools
from trying to create Machine Pools on a not ready or deleted clusterand
If the Machine Pools creation fails for subnet reasons we try to identify if this was because of subnet ids being out of order like described in the ticket and create a MR to
app-interface
to fix the order so the Machine Pools can be updated later.