Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 endpoints-discovery: avoid duplicated urls #4706

Conversation

chassing
Copy link
Contributor

@chassing chassing commented Oct 1, 2024

Several routes may have the same hostname, e.g., if path is used. Remove duplicates and unclutter the app.yml files

Ticket: https://issues.redhat.com/browse/APPSRE-10847

@chassing chassing self-assigned this Oct 1, 2024
@chassing chassing force-pushed the APPSRE-10847/endpoints-discovery-duplicated-urls branch from 60ff049 to 5b91b7a Compare October 3, 2024 07:00
Copy link
Contributor

@hemslo hemslo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chassing chassing force-pushed the APPSRE-10847/endpoints-discovery-duplicated-urls branch from 5b91b7a to cacbeec Compare October 3, 2024 07:16
@chassing chassing merged commit 3a0cbc3 into app-sre:master Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants