print sqs messages on error #4621
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemslo
reviewed
Aug 15, 2024
Comment on lines
+61
to
+70
| try: | ||
| messages = self.sqs.receive_message( | ||
| QueueUrl=self.queue_url, | ||
| VisibilityTimeout=visibility_timeout, | ||
| WaitTimeSeconds=wait_time_seconds, | ||
| ).get("Messages", []) | ||
| return [(m["ReceiptHandle"], json.loads(m["Body"])) for m in messages] | ||
| except Exception as e: | ||
| logging.error(f"Error receiving messages from SQS: {messages=}") | ||
| raise e |
There was a problem hiding this comment.
When there is exception raised in receive_message, messages will be undefined, try to access it will raise another NameError.
If we just want to capture json.loads exceptions, should only put that in try block, and just raise to keep stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sqs consumer fails it would be nice to see the messages it failed on. Usually this stems from some formatting issue which is much easier to spot if we see the message sample in the logs.