Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing gitlab function #4595

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add missing gitlab function #4595

wants to merge 2 commits into from

Conversation

mehfuz
Copy link
Contributor

@mehfuz mehfuz commented Aug 5, 2024 •
edited
Loading

lechuk47
lechuk47 reviewed Aug 5, 2024
View reviewed changes
reconcile/utils/gitlab_api.py Outdated
Comment on lines 383 to 384
groups = self.gl.groups.list()
group = [g for g in groups if g.path == group_name]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
groups = self.gl.groups.list()
group = [g for g in groups if g.path == group_name]
group = [g for g in self.gl.groups.list() if g.path == group_name]

lechuk47
lechuk47 reviewed Aug 5, 2024
View reviewed changes
reconcile/utils/gitlab_api.py Outdated
if not group:
logging.error(group_name + " group not found")
return None, []
[group] = group
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lechuk47 lechuk47 lechuk47 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehfuz @lechuk47