Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vault read kv v2 #94

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

vault read kv v2 #94

wants to merge 2 commits into from

Conversation

maorfr
Copy link

@maorfr maorfr commented Aug 15, 2024

integration is failing when facing a kv v2 secret engine with the following error:

panic: interface conversion: interface {} is nil, not string

goroutine 1 [running]:
github.com/app-sre/go-qontract-reconcile/pkg/aws.getCredentialsFromVault(0x14a8be8?, 0xc000137590?)
	/build/pkg/aws/credentials.go:41 +0x205
github.com/app-sre/go-qontract-reconcile/pkg/aws.GetAwsCredentials({0x14a8be8, 0xc000137590}, 0xc000310750)
	/build/pkg/aws/credentials.go:69 +0xa5
github.com/app-sre/go-qontract-reconcile/internal/accountnotifier.(*AccountNotifier).Setup(0xc0001156c0, {0x14a8be8, 0xc000137590})
	/build/internal/accountnotifier/account_notifier.go:393 +0x85
github.com/app-sre/go-qontract-reconcile/pkg/reconcile.(*IntegrationRunner).runIntegration(0xc000133380)
	/build/pkg/reconcile/integration.go:122 +0x12e
github.com/app-sre/go-qontract-reconcile/pkg/reconcile.(*IntegrationRunner).Run(0xc000133380)
	/build/pkg/reconcile/integration.go:162 +0x90
github.com/app-sre/go-qontract-reconcile/cmd.accountNotifier()
	/build/cmd/account_notifier.go:11 +0x35
github.com/app-sre/go-qontract-reconcile/cmd.init.func2(0xc000142300?, {0x12ee8cf?, 0x4?, 0x12ee8d3?})
	/build/cmd/root.go:40 +0xf
github.com/spf13/cobra.(*Command).execute(0x1ce0660, {0xc000123c40, 0x2, 0x2})
	/go/pkg/mod/github.com/spf13/[email protected]/command.go:987 +0xab1
github.com/spf13/cobra.(*Command).ExecuteC(0x1ce00a0)
	/go/pkg/mod/github.com/spf13/[email protected]/command.go:1115 +0x3ff
github.com/spf13/cobra.(*Command).Execute(...)
	/go/pkg/mod/github.com/spf13/[email protected]/command.go:1039
github.com/app-sre/go-qontract-reconcile/cmd.Execute(...)
	/build/cmd/root.go:65
main.main()
	/build/main.go:7 +0x1b

@maorfr maorfr changed the title vault read fallback on kv v2 vault read kv v2 Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant