Implementing sts to enable an OSD cluster scraper #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suzana Nesic <[email protected]>
BumbleFeng
reviewed
Jul 3, 2023
main.go
Outdated
| awsConfig := aws.NewConfig().WithRegion("us-east-1") | ||
| sess := session.Must(session.NewSession(awsConfig)) | ||
| awsAccountId, err := getAwsAccountNumber(logger, sess) | ||
| if err != nil { | ||
| return collectors, err | ||
| } | ||
| if pkg.LookUpEnvVar("ROLE_ARN") && pkg.LookUpEnvVar("SESSION_NAME") { | ||
| client := sts.New(sess) | ||
| err = pkg.AssumeRole(client, roleARN, sessionName, logger) |
There was a problem hiding this comment.
In order to refresh the token/session, first you need to introduce the DurationSeconds Parameters for AssumeRole. So we can know how often we should refresh the token. Then, we need to write a loop function that looks like CollectLoop which would run AssumeRole before DurationSeconds comes and recreate all sessions in vpcSessions, rdsSessions, ec2Sessions and r53 session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #74 and #78
Part of APPSRE-6382