Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This PR provides a .env file and a note in the readme on how to connect to a mongo database. #30

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

RobertSandiford
Copy link

This PR provides a .env file, .env loading and a note in the readme on how to connect to a mongo database.

This was missing from the default setup, making it unusable without further advice.

Copy link
Member

@boutell boutell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like this was a frustrating situation. FYI it works out of the box without this if mongodb is running on the same computer and is not restricted to require passwords, which is typical when installing community edition on a development machine.

This is something that our documentation could cover better, but I think we'd want to do more internal discussion before adopting dotenv as an official practice. cc @abea

@RobertSandiford
Copy link
Author

RobertSandiford commented Oct 28, 2021

@boutell

Sure. The most helpful thing would just be an explanation in the getting started guide.

Dotenv and an .env file could be provided as a suggestion that people can implement themselves if they want to. Dotenv is pretty standard I think - but I can see you've tried to keep the repo very light on dependencies (generally a good thing).

It's also likely to come up when it comes to deploying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants