New design for public demo #136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoDonkey
approved these changes
Dec 9, 2025
BoDonkey
left a comment
BoDonkey
left a comment
There was a problem hiding this comment.
Spins up and the widgets all test out. I didn't parse through all of the individual code changes, but LGTM.
boutell
reviewed
Dec 9, 2025
| @@ -0,0 +1,15 @@ | |||
| {% area data.widget, 'columns' with { | |||
| aposStyle: '--grid-columns: ' + (data.options.columns or data.manager.options.columns) + ';' + | |||
Member
There was a problem hiding this comment.
Hmm, why do we need this versus what the module does by default?
Member
Author
There was a problem hiding this comment.
there is a project-level class embedded in this markup that the module wouldn't apply where I needed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"
What are the specific steps to test this change?
For example:
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: