Skip to content
This repository has been archived by the owner on Dec 20, 2022. It is now read-only.

Refine provider id warning #62

Merged
merged 3 commits into from
Nov 8, 2019

Conversation

pfistererm
Copy link
Contributor

Refine warning about missing provider ID to include file location

Type of request

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring
  • Documentation or documentation changes

Related Issue(s)

Solves part of #57

Concept

Improve log messages

Description of the change

Changed the log message regarding missing provider ID (occurs during reading of configuration file checkedarchives.csv) to include the file name and the line number or the DocumentLocation in case of reading the XML variant of this file.

Description of current state

Description of target state

Estimated investment / approximate investment

Initiator

Matthias Pfisterer

Technical information

Platform / target area

known side-effects

other

DB Changes (if so: incl. scripts with definitions and testdata)

How has this Tested?

Tested by doing a run with the provided sample configuration on the LicenseScout itself (project org.aposin.licensescout.licensereport) and checked the log messages

Screenshots, Uploads, other documents (if appropriate):

Checklist:

  • All the commits are signed.
  • My code follows the code style of this project.
  • I agree with die CLA.
  • I have read the CONTRIBUTING docs.
  • I have added/updated necessary documentation (if appropriate).

@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #62 into master will increase coverage by 0.09%.
The diff coverage is 58.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #62      +/-   ##
===========================================
+ Coverage     30.31%   30.4%   +0.09%     
- Complexity      242     243       +1     
===========================================
  Files            63      63              
  Lines          2507    2516       +9     
  Branches        301     302       +1     
===========================================
+ Hits            760     765       +5     
- Misses         1680    1683       +3     
- Partials         67      68       +1
Impacted Files Coverage Δ Complexity Δ
...osin/licensescout/util/sax/AbstractSaxHandler.java 74.41% <0%> (-1.78%) 9 <0> (ø)
...org/aposin/licensescout/mojo/AbstractScanMojo.java 1.34% <0%> (-0.01%) 2 <0> (ø)
...posin/licensescout/license/LicenseCheckedList.java 21.03% <77.77%> (+1.64%) 15 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9cfc05...9ac9db4. Read the comment docs.

@davu-all davu-all requested a review from d-gs October 30, 2019 14:10
@d-gs
Copy link
Member

d-gs commented Nov 4, 2019

@pfistererm - could you please rebase on top of the current master and fix the conflicts before reviewing? Thanks!

@davu-all davu-all merged commit b45c864 into aposin:master Nov 8, 2019
@pfistererm pfistererm deleted the mp_refine_provider_id_warning branch November 19, 2019 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants