Skip to content
This repository has been archived by the owner on Dec 20, 2022. It is now read-only.

Refine db configuration warnings #60

Merged

Conversation

pfistererm
Copy link
Contributor

@pfistererm pfistererm commented Oct 30, 2019

The checks for the presence of the parameters buildName, buildVersion and buildUrl only make
sense if writing to the database is actually configured. So to avoid confusion, the checks are made to depend on writeResultsToDatabase

Type of request

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring
  • Documentation or documentation changes

Related Issue(s)

This solves parts of issue #57

Concept

Logging made more clear.

Description of the change

Description of current state

Description of target state

Estimated investment / approximate investment

Initiator

Matthias Pfisterer

Technical information

Platform / target area

known side-effects

other

DB Changes (if so: incl. scripts with definitions and testdata)

How has this Tested?

Did a run with the provided sample configuration and project licensereport.

Screenshots, Uploads, other documents (if appropriate):

Checklist:

  • All the commits are signed.
  • My code follows the code style of this project.
  • I agree with die CLA.
  • I have read the CONTRIBUTING docs.
  • I have added/updated necessary documentation (if appropriate).

@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #60 into master will increase coverage by 0.62%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #60      +/-   ##
===========================================
+ Coverage     30.67%   31.3%   +0.62%     
- Complexity      243     251       +8     
===========================================
  Files            63      63              
  Lines          2494    2495       +1     
  Branches        304     305       +1     
===========================================
+ Hits            765     781      +16     
+ Misses         1661    1646      -15     
  Partials         68      68
Impacted Files Coverage Δ Complexity Δ
...org/aposin/licensescout/mojo/AbstractScanMojo.java 1.34% <0%> (-0.01%) 2 <0> (ø)
...g/aposin/licensescout/configuration/BuildInfo.java 100% <0%> (+100%) 8% <0%> (+8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8637e5...6082e39. Read the comment docs.

@aposin aposin deleted a comment Oct 30, 2019
@davu-all davu-all requested a review from d-gs October 30, 2019 13:16
@aposin aposin deleted a comment Oct 30, 2019
@aposin aposin deleted a comment Oct 31, 2019
@d-gs
Copy link
Member

d-gs commented Nov 4, 2019

@pfistererm - could you please squash the commits and remove irrelevant ones before I start the reivew? Thank you!

@aposin aposin deleted a comment Nov 4, 2019
@aposin aposin deleted a comment Nov 7, 2019
@davu-all
Copy link
Collaborator

davu-all commented Nov 8, 2019

Please clean up the commits.

@aposin aposin deleted a comment Nov 8, 2019
@pfistererm pfistererm force-pushed the mp_refine_db_configuration_warnings2 branch 2 times, most recently from 7393aa3 to 144b00e Compare November 8, 2019 17:52
@pfistererm pfistererm force-pushed the mp_refine_db_configuration_warnings2 branch from 144b00e to 6082e39 Compare November 8, 2019 17:53
@aposin aposin deleted a comment Nov 8, 2019
@pfistererm pfistererm requested review from davu-all and removed request for d-gs November 8, 2019 17:54
@pfistererm
Copy link
Contributor Author

@davu-all managed to clean up the commits - please review now.

@davu-all davu-all merged commit a362ee0 into aposin:master Nov 11, 2019
@pfistererm pfistererm deleted the mp_refine_db_configuration_warnings2 branch November 14, 2019 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants