This repository was archived by the owner on Apr 13, 2023. It is now read-only.
Allow startPolling in useLazyQuery without having to exec first#3645
Open
masad-frost wants to merge 4 commits intoapollographql:masterfrom
Open
Allow startPolling in useLazyQuery without having to exec first#3645masad-frost wants to merge 4 commits intoapollographql:masterfrom
masad-frost wants to merge 4 commits intoapollographql:masterfrom
Conversation
|
@masad-frost: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
Author
|
Also wondering why lazy queries weren't just a convenience for switching |
Author
|
@hwillson Looks like you were interested in looking at the problem in apollographql/apollo-client#5140 This PR explains why this is happening and adds a POC for a solution, lazy queries lose most of their value because of this issue |
Author
|
Any body looks at PR's here? :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Related to apollographql/apollo-client#5140
This is a proof of concept / draft
When using
useLazyQuery, the return value does not includeObservableQueryFields, hence you cannot callstartPollinguntil after you callrunLazyQuerywhich is inconvenient.At the very least the type of the return value of
useLazyQueryshould be modified to indicate thatObservableQueryFieldsmaybe undefined.