This repository was archived by the owner on Apr 13, 2023. It is now read-only.
update type definition of withApollo#3538
Open
liweinan0423 wants to merge 6 commits intoapollographql:masterfrom
Open
update type definition of withApollo#3538liweinan0423 wants to merge 6 commits intoapollographql:masterfrom
liweinan0423 wants to merge 6 commits intoapollographql:masterfrom
Conversation
|
@liweinan0423: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
When can we expect this fix to be released? |
|
@liweinan0423 What is the status of this PR? |
anka-213
reviewed
Mar 24, 2020
| WrappedComponent: React.ComponentType< | ||
| WithApolloClient<Omit<TProps, 'client'>> | ||
| >, | ||
| export function withApollo<TProps extends WithApolloClient<{}>, TResult = any>( |
There was a problem hiding this comment.
Wouldn't this fail if someone has given an explicit TProps argument to withApollo that excludes the WithApolloClient part to make the old version work. For example:
type Props = {user: string}
const ExampleC = ({user, client}: WithApolloClient<Props>) => {...}
const Example = withApollo<Props>(ExampleC)
Here, Props does not extend WithApolloClient<{}> and will cause a type error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this resolves #3392