Swift codegen: Include namespace in fragment struct type names #2397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RobinDaugherty: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
RobinDaugherty
force-pushed
the
fix/fragment-struct-namespace
branch
3 times, most recently
from
dd6232e to
ff2c8e4
Compare
to make sure that if the fragment is used in a query that has a node (and therefore type name) with the same name as the fragment's type name, Swift doesn't get confused about which type is being referred to.
RobinDaugherty
force-pushed
the
fix/fragment-struct-namespace
branch
from
ff2c8e4 to
e510713
Compare
RobinDaugherty
force-pushed
the
fix/fragment-struct-namespace
branch
from
bd89a4d to
e510713
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2396
By placing the namespace in front of any fragment struct name, we can ensure that the fragment type will be unambiguous. If the fragment is used in a query that has a node (and therefore type name) with the same name as the fragment's type name, Swift doesn't get confused about which type is being referred to.
However, the namespace is not included in the name when declaring the fragment's struct, so there's a new method that is used to get the name for its declaration.
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.