Fix a leak related to autoclosure

apollographql · Aug 8, 2024 · 292cca2 · 292cca2
1 parent 104cc94
commit 292cca2
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/Sources/Apollo/ApolloStore.swift b/Sources/Apollo/ApolloStore.swift
@@ -203,7 +203,11 @@ public class ApolloStore {
   public class ReadTransaction {
     fileprivate let cache: any NormalizedCache
 
-    fileprivate lazy var loader: DataLoader<CacheKey, Record> = DataLoader(self.cache.loadRecords)
+    fileprivate lazy var loader: DataLoader<CacheKey, Record> = DataLoader { [weak self] batchLoad in
+        guard let self else { return [:] }
+        return try cache.loadRecords(forKeys: batchLoad)
+    }
+
     fileprivate lazy var executor = GraphQLExecutor(
       executionSource: CacheDataExecutionSource(transaction: self)
     )