Bring back deprecated CodingKey for localCacheMutation in selectionSetInitializers #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
AnthonyMDev
deleted the
fix-config-json-decoding-deprecated-localCacheMutations
branch
BobaFetters
pushed a commit
that referenced
this pull request
Aug 23, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Aug 23, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Aug 23, 2024
a55f4d20 Bring back deprecated CodingKey for localCacheMutation in selectionSetInitializers (#467) git-subtree-dir: apollo-ios-codegen git-subtree-split: a55f4d201031ef88be729ae04b07889041429a96
BobaFetters
pushed a commit
that referenced
this pull request
Aug 23, 2024
… for localCacheMutation in selectionSetInitializers git-subtree-dir: apollo-ios-codegen git-subtree-mainline: e89cc7c git-subtree-split: a55f4d201031ef88be729ae04b07889041429a96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a decoding error when the deprecated option
localCacheMutationsis present in the JSON config. We should ignore the key when decoding, but not throw an error if it's present.This issue was surfaced from this comment on an unrelated issue.