fix: SelectionSetTemplate scope comparison
#460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvincestari
changed the title
SelectionSetTemplate scope comparison
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
AnthonyMDev
approved these changes
Aug 15, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Aug 15, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Aug 15, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Aug 15, 2024
b4d17a62 fix: `SelectionSetTemplate` scope comparison (#460) git-subtree-dir: apollo-ios-codegen git-subtree-split: b4d17a62c7741905b0c62c88ba460374908ffed8
BobaFetters
pushed a commit
that referenced
this pull request
Aug 15, 2024
…pe comparison git-subtree-dir: apollo-ios-codegen git-subtree-mainline: c0c80cf git-subtree-split: b4d17a62c7741905b0c62c88ba460374908ffed8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apollographql/apollo-ios#3424.
Refactored the selection set template scope comparison to account for an edge case in merged sources.