Add Sendable conformance to some basic SchemaTypes #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bdbergeron: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for eclectic-pie-88a2ba pending review.Visit the deploys page to approve it
|
👷 Deploy request for apollo-ios-docc pending review.Visit the deploys page to approve it
|
|
This gets us partway to resolving apollographql/apollo-ios#3291. |
calvincestari
approved these changes
Apr 2, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Apr 2, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Apr 2, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Apr 2, 2024
4851f15b Add Sendable conformance to some basic SchemaTypes (#322) git-subtree-dir: apollo-ios git-subtree-split: 4851f15be36e778c4cfd72162c107f2777430354
BobaFetters
pushed a commit
that referenced
this pull request
Apr 2, 2024
…SchemaTypes git-subtree-dir: apollo-ios git-subtree-mainline: a60b3a4 git-subtree-split: 4851f15be36e778c4cfd72162c107f2777430354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in Swift 5.10 and Xcode 15.3 improved the complete concurrency checking functionality in preparation for Swift 6.0. When using Apollo in a project with complete concurrency checking enabled, many warnings are surfaced for some of the generated schema types such as
Interface,Object, andUnion. These types are simplestructs with no mutability semantics, so they can adoptSendablewithout any further changes or concerns. The same goes forOperationDefinitionandOperationDocumenttypes used in generated queries, mutations, and fragments.