Bump ruby-saml version #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution! Is there a specific issue in 1.7 or 1.8 such that they should no longer be allowed? |
|
No vulnerabilities are fixed since 1.7 AFAIK. it's just bugfixes. Maybe @pitbulk knows something more, though |
|
Yes, not security improvement at all. |
|
In that case, I don't think we need to require a higher version. Application users can upgrade to a higher version without any issues by running |
|
Given this security incident, can we upgrade the |
|
@hauserkristen There's nothing blocking application owners from updating, but yes it would be beneficial to update the minimum version of the dependency to help out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.