Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unescaping for newline #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added unescaping for newline #6

wants to merge 2 commits into from

Conversation

gelin
Copy link

@gelin gelin commented Apr 19, 2019

No description provided.

@apognu
Copy link
Owner

apognu commented Dec 31, 2019

This would merged, but tests do not pass on my end, could you fix them?

--- FAIL: Test_Newline (0.00s)
    gocal_test.go:224: [{[email protected]  line1\nline2\Nline3 [] 2019-04-19 00:00:00 +0000 UTC 20190419 2019-04-18 23:59:59 +0000 UTC 20190419 2017-04-19 17:23:00 +0000 UTC <nil> <nil>  <nil>   <nil> [] [] false  map[] [] 0 map[]}]
    gocal_test.go:226:
                Error Trace:    gocal_test.go:226
                Error:          Not equal:
                                expected: "line1\nline2\nline3"
                                actual  : "line1\\nline2\\Nline3"

                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1,3 +1 @@
                                -line1
                                -line2
                                -line3
                                +line1\nline2\Nline3
                Test:           Test_Newline

@gelin
Copy link
Author

gelin commented Jan 3, 2020

It looks like the test uses an old version of the parser. Wrong modules configuration?

Now I've merged the master to this pull request, and tests work:

$ go version
go version go1.13.5 linux/amd64
$ go test ./...
ok      github.com/apognu/gocal 0.004s
?       github.com/apognu/gocal/examples/custom [no test files]
?       github.com/apognu/gocal/examples/rrule  [no test files]
ok      github.com/apognu/gocal/parser  0.004s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants