This repository was archived by the owner on Aug 3, 2022. It is now read-only.
add sqlite type for each column to _transicator_tables #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -232,7 +234,16 @@ var _ = Describe("Snapshot API Tests", func() { | |||
| Expect(r["created_by"]).Should(Equal(1)) | |||
| Expect(r["id"]).Should(Equal(2)) | |||
| Expect(r["_change_selector"]).Should(Equal(2)) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
What about other data types, other than text and blob?
|
@f1erro as we discussed -- if it turns out that we don't need this, let's hold off. Let me know if this is necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should propagate the sqlite type that transicator decided to convert the original PG type into, since that info is readily available during db construction time, and will save consumers the burden of inspecting the db for this metadata. This info is necessary to construct the proper dml for changes.