fix: use shared enqueue links wrapper in AdaptivePlaywrightCrawler
#3188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbuchar
reviewed
Oct 7, 2025
packages/playwright-crawler/src/internals/adaptive-playwright-crawler.ts
Outdated
Show resolved
Hide resolved
Contributor
|
Note - this will be fun to merge with #3119 |
Patai5
force-pushed
the
fix/adaptive-playwright-crawler-crawl-depth
branch
from
498ec43 to
0a94f70
Compare
Patai5
changed the base branch from
master
to
refactor/avoid-lets-from-timeout-and-retry
Patai5
force-pushed
the
fix/adaptive-playwright-crawler-crawl-depth
branch
from
0a94f70 to
31edb70
Compare
Contributor
Author
|
I've fixed all of the remarks under this one: Force pushed for a rebase onto: |
Patai5
added a commit
that referenced
this pull request
Oct 24, 2025
Fixes #3188 (comment) in a separate PR for clean history and review Ensures that the underlying retries are awaited properly, so that 1. the main promise does not resolve early, which could've caused race conditions on usage of this method 2. they do not lead to orphan non-awaited promises, that if they throw an error, it propagates all the way to the root level of runtime, causing it to crash
Patai5
changed the base branch from
refactor/avoid-lets-from-timeout-and-retry
to
master
Patai5
force-pushed
the
fix/adaptive-playwright-crawler-crawl-depth
branch
from
31edb70 to
3185919
Compare
Contributor
Author
janbuchar
reviewed
Oct 24, 2025
Contributor
janbuchar
left a comment
janbuchar
left a comment
There was a problem hiding this comment.
Mostly LGTM, just a few comments
Contributor
Author
|
Let me know if you consider everything as resolved 👍 Otherwise, I consider this done :) |
B4nan
changed the title
AdaptivePlaywrightCrawler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the adaptive playwright crawler's issue of not using the new crawl depth implementation of
enqueueLinksDiscovered in WCC here:
enqueueLinkswrapper into a new method of the basic crawler -_crawlingContextEnqueueLinksWrapperUp for discussion:
addRequestswrapper -_crawlingContextAddRequestsGeneratorOnly after finishing up my tests, I realized that this one is not actually needed :D Let me know if you think we should keep it or move it back :) It seems like a nice standalone function, but maybe we should keep it as
privateand notprotected🤔_crawlingContextEnqueueLinksWrapper?