Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Expose event types, improve on/emit signature, allow parameterless listeners #800

Merged
merged 6 commits into from
Dec 16, 2024
Merged

feat: Expose event types, improve on/emit signature, allow parameterless listeners #800

merged 6 commits into from
Dec 16, 2024

Conversation

janbuchar
Copy link
Collaborator

@janbuchar janbuchar commented Dec 10, 2024 •
edited
Loading

@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Dec 10, 2024
@github-actions github-actions bot added this to the 104th sprint - Tooling team milestone Dec 10, 2024
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Dec 10, 2024
@janbuchar janbuchar mentioned this pull request Dec 10, 2024
Draft
@Mantisus Mantisus mentioned this pull request Dec 14, 2024
Closed
@janbuchar janbuchar requested a review from vdusek December 16, 2024 14:12
@Pijukatel Pijukatel self-requested a review December 16, 2024 14:42
vdusek
vdusek approved these changes Dec 16, 2024
View reviewed changes
src/crawlee/events/_types.py Outdated Show resolved Hide resolved
@janbuchar janbuchar merged commit c102c4c into master Dec 16, 2024
23 checks passed
@janbuchar janbuchar deleted the improve-event-types branch December 16, 2024 16:07
@B4nan
Copy link
Member

B4nan commented Dec 17, 2024

If you wanted to close both of the issue listed in the description, you need to have Closes #... for both of them. The second issue is still opened now.

@janbuchar
Copy link
Collaborator Author

If you wanted to close both of the issue listed in the description, you need to have Closes #... for both of them. The second issue is still opened now.

I wanted it this way - the second one is waiting for SDK to start using Crawlee 0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pijukatel Pijukatel Pijukatel approved these changes

@vdusek vdusek vdusek approved these changes

Assignees

@janbuchar janbuchar

Labels
t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
104th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.

Expose possible event types from crawlee._events
4 participants
@janbuchar @B4nan @vdusek @Pijukatel