Skip to content

fix: Update templates to handle optional httpx client #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

fix: Update templates to handle optional httpx client #1440

merged 1 commit into from
Oct 2, 2025

Conversation

Pijukatel
Copy link
Collaborator

Description

  • Update templates to handle optional httpx client.

Testing

  • Running E2E template tests

@github-actions github-actions bot added this to the 124th sprint - Tooling team milestone Sep 30, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Sep 30, 2025
@Pijukatel Pijukatel added the adhoc Ad-hoc unplanned task added during the sprint. label Sep 30, 2025
@Pijukatel Pijukatel requested a review from vdusek September 30, 2025 13:03
@Pijukatel
Copy link
Collaborator Author

Pijukatel commented Sep 30, 2025 •
edited
Loading

Failed master E2E tests:
https://github.com/apify/crawlee-python/actions/runs/18120549849
On this branch E2E tests:
https://github.com/apify/crawlee-python/actions/runs/18130587136

  • Failing Camoufox templates are some performance issue as the templates are running very slowly with Camoufox.

@Pijukatel Pijukatel marked this pull request as ready for review October 1, 2025 06:37
vdusek
vdusek approved these changes Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek mentioned this pull request Oct 1, 2025
Merged
@Pijukatel
Copy link
Collaborator Author

Ignoring the failing test due to #1441

@Pijukatel Pijukatel merged commit c087efd into master Oct 2, 2025
152 of 167 checks passed
@Pijukatel Pijukatel deleted the update-templates-to-handle-optional-httpx branch October 2, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

Assignees

@Pijukatel Pijukatel

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
124th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@Pijukatel @vdusek