fix: prevent silent loss of reclaimed requests during queue head propagation#1060
Draft
vdusek wants to merge 4 commits into
Draft
fix: prevent silent loss of reclaimed requests during queue head propagation#1060vdusek wants to merge 4 commits into
vdusek wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1060 +/- ##
==========================================
+ Coverage 91.89% 92.00% +0.10%
==========================================
Files 51 51
Lines 3232 3238 +6
==========================================
+ Hits 2970 2979 +9
+ Misses 262 259 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A request reclaimed with the default
forefront=False(crawlee'sBasicCrawlerretry path) was written only to_requests_cache, whichis_empty()andis_finished()never consult — they read the local head estimate. With the request in no head structure, both reported the queue finished while the platform head listing still lagged behind the reclaim. Near queue exhaustion,AutoscaledPoolpollsis_finished(), getsTruefrom the lagging head, and shuts the run down: the request stays pending in the queue forever while the run reports success.The fix re-enters the reclaimed id at the back of the local head estimate (
_head_requests.appendleftfor the single client,_queue_head.appendfor the shared client), mirroringadd_batch_of_requestsand the existingforefront=Truebranch, so the request is retried instead of dropped. Theforefront=Truepaths are unchanged.Regression tests for both clients reclaim a request while the mocked platform head lags and assert
is_empty()/is_finished()stayFalse— they fail before the fix.✍️ Drafted by Claude Code