Skip to content

docs: Key-value store schema page #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jul 4, 2025
Merged

docs: Key-value store schema page #1645

merged 19 commits into from
Jul 4, 2025

Conversation

MFori
Copy link
Member

@MFori MFori commented Jun 23, 2025 •
edited
Loading

@MFori MFori self-assigned this Jun 23, 2025
@MFori MFori added the t-console Issues with this label are in the ownership of the console team. label Jun 23, 2025
@github-actions github-actions bot added this to the 117th sprint - Console team milestone Jun 23, 2025
@apify-service-account
Copy link

Preview for this PR was built for commit 2e1555b and is ready at https://pr-1645.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit 06b6cd64 and is ready at https://pr-1645.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit ff5ffd49 and is ready at https://pr-1645.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit bb7cebd1 and is ready at https://pr-1645.preview.docs.apify.com!

@MFori MFori requested a review from gippy June 24, 2025 18:16
@MFori MFori marked this pull request as ready for review June 24, 2025 18:16
@MFori MFori requested a review from TC-MO as a code owner June 24, 2025 18:16
@MFori
Copy link
Member Author

MFori commented Jul 3, 2025

Ping @TC-MO

TC-MO
TC-MO requested changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes requested for clarity, conciseness, and clarity.
Rewrote in few places for more direct voice

...velopment/actor_definition/key_value_store_schema/images/kv-store-schema-example-storage.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you have a plan on that account and that is why the data retention is different than default 7 days?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I updated the image from account with default data retention

@TC-MO
Copy link
Contributor

TC-MO commented Jul 3, 2025

My utmost apologies, I made the review and forgot to click on the "Request changes" 🤦‍♂️

MFori and others added 8 commits July 3, 2025 22:38
@MFori @TC-MO
Update sources/platform/actors/development/actor_definition/key_value…
8f75ca9 
…_store_schema/index.md

Co-authored-by: Michał Olender <[email protected]>
@MFori @TC-MO
Update sources/platform/actors/development/actor_definition/key_value…
4d9a9c5 
…_store_schema/index.md

Co-authored-by: Michał Olender <[email protected]>
@MFori @TC-MO
Update sources/platform/actors/development/actor_definition/key_value…
9c6d246 
…_store_schema/index.md

Co-authored-by: Michał Olender <[email protected]>
@MFori @TC-MO
Update sources/platform/actors/development/actor_definition/key_value…
04f9d60 
…_store_schema/index.md

Co-authored-by: Michał Olender <[email protected]>
@MFori @TC-MO
Update sources/platform/actors/development/actor_definition/key_value…
c7d9905 
…_store_schema/index.md

Co-authored-by: Michał Olender <[email protected]>
@MFori @TC-MO
Update sources/platform/actors/development/actor_definition/key_value…
4db938b 
…_store_schema/index.md

Co-authored-by: Michał Olender <[email protected]>
@MFori @TC-MO
Update sources/platform/actors/development/actor_definition/key_value…
a70f60c 
…_store_schema/index.md

Co-authored-by: Michał Olender <[email protected]>
@MFori @TC-MO
Update sources/platform/actors/development/actor_definition/key_value…
7ae5bfa 
…_store_schema/index.md

Co-authored-by: Michał Olender <[email protected]>
@apify-service-account
Copy link

Preview for this PR was built for commit 8f75ca92 and is ready at https://pr-1645.preview.docs.apify.com!

MFori and others added 2 commits July 3, 2025 22:41
MFori and others added 2 commits July 3, 2025 22:41
@apify-service-account
Copy link

Preview for this PR was built for commit 5976c526 and is ready at https://pr-1645.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit ff648538 and is ready at https://pr-1645.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit 6e064fd8 and is ready at https://pr-1645.preview.docs.apify.com!

@MFori MFori requested a review from TC-MO July 3, 2025 21:01
TC-MO
TC-MO approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one capitalization fix, otherwise LGTM

@MFori @TC-MO
Update sources/platform/actors/development/actor_definition/key_value…
30d395b 
…_store_schema/index.md

Co-authored-by: Michał Olender <[email protected]>
@apify-service-account
Copy link

Preview for this PR was built for commit 30d395b1 and is ready at https://pr-1645.preview.docs.apify.com!

@MFori MFori merged commit 1dede5f into master Jul 4, 2025
10 checks passed
@MFori MFori deleted the feat/kv-store-schema-page branch July 4, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gippy gippy gippy approved these changes

@TC-MO TC-MO TC-MO approved these changes

Assignees

@MFori MFori

Labels
t-console Issues with this label are in the ownership of the console team.
Projects
None yet
Milestone
117th sprint - Console team
Development

Successfully merging this pull request may close these issues.
4 participants
@MFori @apify-service-account @TC-MO @gippy