refactor: Improve JsonSerializable type to be recursive#745
Merged
Conversation
Replace the loose `dict[str, Any] | list[Any]` variants with recursive references so nested JSON values are now properly typed instead of falling back to `Any`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
==========================================
- Coverage 95.36% 95.29% -0.08%
==========================================
Files 45 45
Lines 5118 5118
==========================================
- Hits 4881 4877 -4
- Misses 237 241 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
janbuchar
reviewed
Apr 21, 2026
Contributor
janbuchar
left a comment
There was a problem hiding this comment.
This is part of the public interface via UserData, right? So the change is technically breaking for users of type checkers that cannot handle recursive types. Do we consider it a problem?
Contributor
Author
|
See this comment from the end of 2022:
So I wouldn't be afraid of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the loose
dict[str, Any] | list[Any]variants ofJsonSerializablewith recursive references so nested JSON values are properly typed instead of falling back toAny. Based on the definition discussed in python/typing#182.