Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed client_secret missing if client_id is provided as body param #92

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nilswieber
Copy link

@nilswieber nilswieber commented Sep 30, 2017

Sometimes OAuthClients do a TokenRequest with the client_id in the body (without the client_secret) and provide client_id and client_secret in the authorization header.

So the clientId would be !=null but the clientSecret == null.
In that case the authorization header won't be evaluated.

This pull request fixes this issue.

@rossitsaborissova
Copy link
Contributor

Please, add a unit test for that case. Also, please add the issue number in your commit messages, i.e. "[Issue #92] Fixed client_secret missing if client_id is provided as body param" for the current issue. Thanks!

@rossitsaborissova
Copy link
Contributor

Please, see my previous comment.
Thanks for your interest in the project.

@rossitsaborissova
Copy link
Contributor

I logged an issue for that problem and send a pull request - #95. The connectTimeout and mongo-java-driver issues will be logged as separate tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants