feat: new version ingress controller helm chart #175
Merged
+12,184
−3,261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new version of the ingress controller Helm chart, renaming and refactoring resources from the legacy "api7‑ingress‑controller" to "apisix‑ingress‑controller‑manager" while removing several legacy and potentially redundant resources.
- Renames templates, labels, and helper functions to align with the new naming convention.
- Removes legacy Kubernetes resources (e.g. HPA, RBAC, several CRDs, NOTES.txt, .helmignore) and updates deployment configurations.
- Updates Chart metadata and README to reflect the new version and repository.
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/ingress-controller/templates/service-apisix.yaml | Removed legacy APISIX Gateway Service definition. |
| charts/ingress-controller/templates/service-account.yaml | Adjusted service account naming and added updated label definitions. |
| charts/ingress-controller/templates/role_binding.yaml | Introduced new RoleBinding with updated labels and naming. |
| charts/ingress-controller/templates/role.yaml | Added new Role with updated rules and labels. |
| charts/ingress-controller/templates/rbac.yaml | Removed ClusterRole and ClusterRoleBinding resources. |
| charts/ingress-controller/templates/pdb.yaml | Updated naming from legacy names to the new naming convention. |
| charts/ingress-controller/templates/hpa.yaml | Removed HPA resource definitions. |
| charts/ingress-controller/templates/deployment.yaml | Overhauled deployment configuration with new image, probes, and volume mounts. |
| charts/ingress-controller/templates/configmap.yaml | Refactored ConfigMap name and configuration content. |
| charts/ingress-controller/templates/cluster_role_binding.yaml | Added updated ClusterRoleBinding definitions with new labels. |
| charts/ingress-controller/templates/cluster_role.yaml | Introduced new ClusterRole resources conforming to updated RBAC rules. |
| charts/ingress-controller/templates/_helpers.tpl | Renamed helper function definitions to reflect new naming. |
| charts/ingress-controller/templates/NOTES.txt | Removed NOTES file. |
| charts/ingress-controller/crds/*.yaml | Removed several CRDs (ApisixTls, ApisixPluginConfig, ApisixGlobalRule, ApisixClusterConfig). |
| charts/ingress-controller/README.md | Renamed project title and updated version badges and documentation. |
| charts/ingress-controller/Chart.yaml | Updated chart metadata including name, description, version, and maintainers. |
| charts/ingress-controller/.helmignore | Removed .helmignore file from the chart package. |
dspo
approved these changes
May 22, 2025
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| name: {{ .Release.Name }}-apisix-ingress-manager-role |
There was a problem hiding this comment.
charts/ingress-controller/README.md
Outdated
| @@ -1,99 +1,57 @@ | |||
| # api7-ingress-controller | |||
| # apisix-ingress-controller-manager | |||
There was a problem hiding this comment.
这个是否有必要换名字呢？以后是否可能有 api7 专有功能呢。不过下面 Source Code 指向了开源仓库，换名字也没啥问题。
There was a problem hiding this comment.
+1,
Shouldn't it be an API7 ingress controller image.
AlinsRan
approved these changes
May 22, 2025
Signed-off-by: ashing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.